Support naver webtoon #1331
Merged
Support naver webtoon #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The regex patterns are weird, for one. (optional domain, capturing the static '/webtoon/', etc), You can find a patch that fixes most of them at |
|
@mikf Thank you for review! I'm going to take a look on weekend. |
|
Just added test results. Not sure If I've done right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spend whole Sunday to add Extractor for Naver webtoon. I made scraper for this website so I'm pretty sure that I understand everything about this website.
I am not familiar with this project yet. I tried to make it work, but it doesn't seem to work.
Can you give me some advice?